[BPF] Remove unused weak symbol __bpf_trap #166003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
Nikita Popov reported an issue ([1]) where a dangling weak symbol __bpf_trap is in the final binary and this caused libbpf failing like below: $ veristat -v ./t.o Processing 't.o'... libbpf: elf: skipping unrecognized data section(4) .eh_frame libbpf: elf: skipping relo section(5) .rel.eh_frame for section(4) .eh_frame libbpf: failed to find BTF for extern '__bpf_trap': -3 Failed to open './t.o': -3 In llvm, the dag selection phase generates __bpf_trap in code. Later the UnreachableBlockElim pass removed __bpf_trap from the code, but __bpf_trap symbol survives in the symbol table. Having a dangling __bpf_trap weak symbol is not good for old kernels as seen in the above veristat failure. Although users could use compiler flag '-mllvm -bpf-disable-trap-unreachable' to workaround the issue, this patch fixed the issue by removing the dangling __bpf_trap. [1] llvm#165696
yonghong-song
force-pushed
the
fix-bpf-trap
branch
from
f6f3c28 to
fd849b2
Compare
Contributor
|
cc @tuliom Would be good to confirm whether this fixes the issues you saw on RHEL 8. |
eddyz87
reviewed
Nov 3, 2025
eddyz87
approved these changes
Nov 3, 2025
rupprecht
reviewed
Nov 4, 2025
| if (GV->getName() == BPF_TRAP) | ||
| SawTrapCall = true; | ||
| } else if (Op.isSymbol()) { | ||
| if (const MCSymbol *Sym = Op.getMCSymbol()) |
Collaborator
There was a problem hiding this comment.
This will always fire an assertion:
MCSymbol *getMCSymbol() const {
assert(isMCSymbol() && "Wrong MachineOperand accessor");
return Contents.Sym;
}But isMCSymbol() is always false since isSymbol() is true instead.
What's the right fix?
Contributor
Author
There was a problem hiding this comment.
I used Op.isSymbol() as a possible target but running bpf selftest, the branch with Op.isSymbol() never to be true, at least when running linux kernel bpf selftests.
Let me double check whether this branch isSymbol() is really necessary or not.
Contributor
Author
|
The BPF_TRAP is created as So BPF_TRAP will be used as a global in instructions. So the branch should be considered as dead code and can be removed. WDYT? |
yonghong-song
pushed a commit
to yonghong-song/llvm-project
that referenced
this pull request
Nov 4, 2025
In [1], the symbol __bpf_trap (macro BPF_TRAP) is removed if it is not used in the code. In the discussion in [1], it is found that the branch "if (Op.isSymbol())" is actually always false. Remove it to avoid confusion. [1] llvm#166003
yonghong-song
added a commit
that referenced
this pull request
Nov 4, 2025
In [1], the symbol __bpf_trap (macro BPF_TRAP) is removed if it is not used in the code. In the discussion in [1], it is found that the branch "if (Op.isSymbol())" is actually always false. Remove it to avoid confusion. [1] #166003
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Nov 4, 2025
…166440) In [1], the symbol __bpf_trap (macro BPF_TRAP) is removed if it is not used in the code. In the discussion in [1], it is found that the branch "if (Op.isSymbol())" is actually always false. Remove it to avoid confusion. [1] llvm/llvm-project#166003
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nikita Popov reported an issue ([1]) where a dangling weak symbol __bpf_trap is in the final binary and this caused libbpf failing like below:
In llvm, the dag selection phase generates __bpf_trap in code. Later the UnreachableBlockElim pass removed __bpf_trap from the code, but __bpf_trap symbol survives in the symbol table.
Having a dangling __bpf_trap weak symbol is not good for old kernels as seen in the above veristat failure. Although users could use compiler flag
-mllvm -bpf-disable-trap-unreachableto workaround the issue, this patch fixed the issue by removing the dangling __bpf_trap.[1] #165696